feat: bidder node: Include shutter specific fields

[blockchainluffy]

Describe your changes

Bid Option is extended to include identity prefix and encrypted transaction.
Identity Prefix: random 32 bytes used to encrypt transaction and generate decryption keys.
Encrypted transaction: the shutter encrypyted plaintext transaction.

The TransactionHash field is reused to send the user transaction hash

Issue ticket number and link

Fixes # (issue)

Checklist before requesting a review

• I have added tests that prove my fix is effective or that my feature works
• I have made corresponding changes to the documentation

[aloknerurkar]

Nice work! Apart from the minor comment about protobuf validation mostly looking good!

[aloknerurkar]

We use the protobuf validation plugin usually to do validation checks. These checks can be mentioned in the proto file using expressions and the call above to Validate on L148 will do all the validations. There are tests also which will verify the error message you will get.

There are plenty of examples in the proto files to help you get started. For eg this

These are examples of tests. The error message carries the field name.

[blockchainluffy]

thank you for detailed explanation!
added protobuf validation in 1d4f6c5

[aloknerurkar]

We use conventional commit format for the PRs. Its not that strict but something like:
feat: small description should be good. Currently the CI integration tests are not working as we are in process of migrating the CI to use kubernetes instead of nomad. So hopefully you can verify the changes by running manual tests on hoodi. If you need help deploying a small devnet locally to test we can help there.

[blockchainluffy]

We use conventional commit format for the PRs. Its not that strict but something like: feat: small description should be good. Currently the CI integration tests are not working as we are in process of migrating the CI to use kubernetes instead of nomad. So hopefully you can verify the changes by running manual tests on hoodi. If you need help deploying a small devnet locally to test we can help there.

Thank you @aloknerurkar for the feedback!
I have verified changes by running manual tests on hoodi, I was receiving confirmations from provider for these bids as well before, but yesterday I got the message error sending bid: no providers available. I hope this is just as fine.

For commit formats, should I recreate this PR with updated commits, or we can let it go this time?

[aloknerurkar]

We don't look at the individual commits right now. The CI will only run this on the PR title. So your individual commits are fine.

When you squash and merge in the end, remove all the individual commit information and just keep the title.