fix: check confirmation for preconfirmed txns and add subsidy#836
Merged
aloknerurkar merged 15 commits intomainfrom Oct 22, 2025
Merged
fix: check confirmation for preconfirmed txns and add subsidy#836aloknerurkar merged 15 commits intomainfrom
aloknerurkar merged 15 commits intomainfrom
Conversation
harshsingh1002
approved these changes
Oct 20, 2025
added 9 commits
October 21, 2025 02:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Previously if we consider transaction as preconfirmed, we dont wait to check for transaction being in the block. With this change we will always check for inclusion.
Because of the above change, we will have to consider PreConfirmed state as a step before confirmation. So when we return receipts, we will not proxy request if it is preconfirmed.
Also added logic to provide subsidy to bidders for initial testing.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review