fix: improvements to retry logic in RPC#849
Merged
aloknerurkar merged 16 commits intomainfrom Nov 17, 2025
Merged
Conversation
aloknerurkar
force-pushed
the
rpc-fixes.15
branch
from
4fd006f to
03b3bf5
Compare
harshsingh1002
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The sync checking of inclusion leads to delays around the block boundary. The changes now make the checking async. We will keep retrying till we get the signal.
One case to consider is if we retried for the next block when we already had commitments for the previous block. If we got the inclusion signal late, this would mean that the previous commitments/block number were infact the correct ones. So we should use those when we confirm.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review