Conversation
owen-eth
changed the title
owen-eth
changed the title
kant777
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
-Cap user-supplied slippage at 2% before calling Barter (Barter's max), in both CallBarterAPI (Path 1) and CallBarterAPIForETH (Path 2). Higher user tolerances now route successfully instead of being rejected by Barter.
-UserAmtOut (user's minAmountOut) is untouched and still enforced via the existing outAmt < UserAmtOut check, so any actual slippage between 2% and the user's tolerance flows through as settlement surplus → more miles.
-Added Info log when slippage is capped (with requested value + path) and Warn log when slippage is unparseable or out of [0, 100] (falls back to existing 0.5% default — no behavior change, just visibility).
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review