Conversation
[fix] Don't send CORS headers for the client or other requests.
This reverts commit a83a5bd. Conflicts: transformer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proper CORS support directly in Primus instead of assuming that our transformers implement it correctly. Fixes #142. In addition to fixing this feature request in Primus it should also correctly fix the following bugs in the supported real-time "transformers":
socketio/socket.io#12
socketio/socket.io#764
socketio/socket.io#194
socketio/socket.io#1025
socketio/socket.io#1442
socketio/socket.io#547
socketio/socket.io#1214
socketio/socket.io#1046
socketio/socket.io#986