Skip to content

Fix bugs with cache and connection #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fjorgemota wants to merge 2 commits into from
Closed

Fix bugs with cache and connection #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0814f6b
Fix bug where preview_session method does not use specified cache
fjorgemota Jul 15, 2015
8962ff8
Fix bug where Cache-Control header is not found
fjorgemota Jul 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prismic/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def preview_session(self, token, link_resolver, default_url):

:return: the URL to redirect the user to
"""
main_document_id = get_json(token, request_handler=self.request_handler).get("mainDocument")
main_document_id = get_json(token, request_handler=self.request_handler, cache=self.cache).get("mainDocument")
if main_document_id is None:
return default_url
response = self.form("everything").ref(token).query(predicates.at("document.id", main_document_id)).submit()
Expand Down
2 changes: 1 addition & 1 deletion prismic/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def get_json(url, params=None, access_token=None, cache=None, ttl=None, request_


def get_max_age(headers):
expire_header = headers["Cache-Control"]
expire_header = headers.get("Cache-Control")
Copy link
Contributor

@pconerly pconerly Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, drats, I missed this PR--- I also fixed it over here. #26

Copy link
Contributor Author

@fjorgemota fjorgemota May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, so i'll close the PR..

Thanks for the alert. :)

if expire_header is not None:
m = re.match("max-age=(\d+)", expire_header)
if m:
Expand Down