This repository was archived by the owner on Oct 15, 2020. It is now read-only.
[WIP] Pick preset points from curve model#76
Open
joshuathayer wants to merge 3 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how we pick "canned" sets of points, to use our curve model with intervened degree and coefficients rather than hardcoded locations.
This demonstrates two curve sets-
y = 0.5x, which approximates the 0th column in the NIPS "slide 21", andy = 0.5x^2 + 2x, which approximates the 2nd column on that slide. The other preset points have not yet been implemented.As before, the sets can be cycled by pressing
p.Note that I significantly reduce the "inlier" noise value in
add-noise-to-curve- it was set to 1, which resulted in points all over the place.[WIP] can be removed once other point distributions are implemented.