Skip to content
This repository was archived by the owner on Feb 28, 2021. It is now read-only.

Comments

reduce MAX_OBJECTS to 20. Give description only for 20 elements#113

Merged
lm-n merged 3 commits intomasterfrom
no-elements
Aug 25, 2018
Merged

reduce MAX_OBJECTS to 20. Give description only for 20 elements#113
lm-n merged 3 commits intomasterfrom
no-elements

Conversation

@MathuraMG
Copy link
Collaborator

This PR is to fix the issue that if we have more than the maximun number of elements we can support, the text output breaks.
This is with relation to issue in p5 examples
Before your pull request is reviewed and merged, make sure you

  • there are no linting/build errors -- npm run build
  • code is in uniquely-named feature branch, and has been rebased on top of latest master. If you're asked to make more changes make sure you rebase onto master then too!
  • pull request is descriptively named and links to an issue number, i.e. Fixes #123

Thank you!

@MathuraMG MathuraMG requested a review from lm-n August 16, 2018 16:15
@lm-n
Copy link
Member

lm-n commented Aug 17, 2018

@MathuraMG this PR does not rename arguments is that in another PR?

@MathuraMG
Copy link
Collaborator Author

@lm-n yes, I made a separate PR for that #118

Copy link
Member

@lm-n lm-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lm-n lm-n merged commit 52c08d1 into master Aug 25, 2018
@lm-n lm-n deleted the no-elements branch August 25, 2018 17:46
@lm-n lm-n restored the no-elements branch August 25, 2018 23:52
@lm-n lm-n deleted the no-elements branch September 8, 2018 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants