convert Sidebar to a function component & connect it to Redux#2233
Merged
raclim merged 3 commits intoprocessing:developfrom Jul 18, 2023
Merged
convert Sidebar to a function component & connect it to Redux#2233raclim merged 3 commits intoprocessing:developfrom
raclim merged 3 commits intoprocessing:developfrom
Conversation
raclim
approved these changes
Jul 18, 2023
Collaborator
raclim
left a comment
There was a problem hiding this comment.
Thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #824
Changes:
Sidebarfrom a class component to a function component.Sidebarcomponent.IDEViewwhich were only passed down toSidebarand not otherwise used.useSelector.userCanEditProject()into a reusable selector functionselectCanEditSketch.dispatchwith theuseDispatchhook and import all actions creators directly.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123