Add theme switching to Storybook#2326
Conversation
|
Trying out this feature with all of the new stories added in #2398 has revealed a bunch of things which are not handled perfectly. TODOs:
|
|
This is awesome! Its really nice to be able to isolate and explore components with a theme. The One idea for a view with all themes is to mimic Compositions https://bit.cloud/teambit/design/inputs/select
Storybook has MDX support so you could use your But these are just ideas for the future. I think whats here is an enhancement by exposing the theme in the first place. It can be iterated on in the future if needed. |
| @@ -21,5 +21,9 @@ export const decorators = [ | |||
| </MemoryRouter> | |||
There was a problem hiding this comment.
It looks like ThemeProvider has moved to the withThemeProvider HOC. Might need to remove <ThemeProvider> as well.

Changes:
Could be improved if I make the background fill the entire preview area.
@ofhope - thoughts?
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123