Connect ShareModal to Redux.#2328
Merged
raclim merged 5 commits intoprocessing:developfrom Mar 29, 2024
Merged
Conversation
PiyushChandra17
approved these changes
Nov 1, 2023
Contributor
PiyushChandra17
left a comment
PiyushChandra17
left a comment
There was a problem hiding this comment.
Nicely Done, looks good to me.
…odal # Conflicts: # client/modules/IDE/pages/IDEView.jsx # client/modules/IDE/components/IDEOverlays.jsx
raclim
approved these changes
Mar 29, 2024
Collaborator
raclim
left a comment
raclim
left a comment
There was a problem hiding this comment.
Just ran this branch and it seems good to me! Thanks so much!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #824
These changes were also part of #2054, but I think that I did too much in that PR and I will re-submit it in pieces.
Changes:
ShareModaltakes no props.ShareModalaccesses values from Redux viauseSelector.IDEViewdoes not pass any props down toShareModal.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123