Convert Preferences into a function component#2335
Merged
raclim merged 7 commits intoprocessing:developfrom Aug 11, 2023
Merged
Convert Preferences into a function component#2335raclim merged 7 commits intoprocessing:developfrom
Preferences into a function component#2335raclim merged 7 commits intoprocessing:developfrom
Conversation
24 tasks
4 tasks
raclim
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on issue #824
Continue breaking up PR #2054 into more manageable pieces. Here I am converting
Preferencesfrom a class component to a function component while keeping all the logic the same. I'm not including the improvements to the font size input which were causing tests to fail. I will submit those separately.Should be merged after #2329
Changes:
PreferencesuseSelectoranduseDispatchinstead ofconnectHOC.useTranslatehook instead ofwithTranslationHOC.useRefhook instead of propertythis.fontSizeInput.useStatehook for the fontSize state. I tried to keep this as similar to before as possible so I made thestatebe an object even though this is silly.Preferences.unit.test.jsxsubjectnow takes the initial state as an argument.beforeAlleffects, which were used to set props.subjectwith the relevant initial state for each test, ie.subject({ lintWarning: false }).setLintWarningetc. and spy on on the action creator instead.propsso that tests likeexpect(props.setFontSize).toHaveBeenCalledTimes(1);will work the same as before, even though it's not actually a prop.expectconditions as there is no change to behavior.IDEView<Preferences/>.propTypes.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123