Useable Mobile Editor 🎉#2387
Conversation
…s-web-editor into dewanshmobile/ide
lindapaiste
left a comment
There was a problem hiding this comment.
Some first thoughts. Will continue reviewing later.
|
|
||
| > header { | ||
| display: flex; | ||
| ${prop('MobilePanel.secondary')} |
There was a problem hiding this comment.
Looks like we’ve got a value with no property? Here and on line 21.
There was a problem hiding this comment.
no this is to set the background color, it automatically does that
There was a problem hiding this comment.
we can also change all the foreground key in the theme to color to set the color and background automaticall by just writing this one line ${prop('some object background and color property')}
There was a problem hiding this comment.
Right, I see what you’re saying. You put the “color:” part in the theme object. So it’s like a mixin rather than a color variable.
|
We discussed how a lot of the prevProps comparisons could be avoided if you handled each useEffect separately with the dependency on the prop you are trying to detect changes in. |
|
yeah I remember that, will work on all the changes now |
|
hey @lindapaiste, Just made all the changes and push the code check it out! |
…s-web-editor into dewanshmobile/ide
Co-authored-by: Linda Paiste <lindapaiste@gmail.com>
…s-web-editor into dewanshmobile/ide
* cleanup unused vars * add dependencies to `useEffect`s
cleanup IDEView
Fixes #issue-number
Changes:
The useable editor is now available in mobile!!

before merging this, following PRs need to be merged
#2052
#2347
#2362
I have verified that this pull request:
npm run lint)npm run test)developbranch.