pr05 Typescript #4: migrate instance of react file

[clairep94]

pr05 Typescript Migration 4: Migrate instance of react file

IMPORTANT: Should be reviewed after #3540 for clarity

• This branch is built off of the branch for pr05 Typescript #2: automatically resolve imports of ts files & migrate instance of client/utils file #3540
• Relevant commits start at 5b1fd1e

Context:

• Migrate an instance of a React file from jsx to tsx to confirm typescript config works as expected

Changes:

• Migrate client/components/SkipLink.jsx to client/components/SkipLink.tsx with git mv ....
  • typecheck flags this file with missing types errors as expected
  • Initial commit done with --no-verify flag to bypass the typecheck
• Add unit test for SkipLink.tsx
• Update ts/tsx eslint overrides
  • Without these overrides, eslint would flag these on SkipLink.tsx
  • I'll look into doing the Google-Typescript linting config as the next priority, and perhaps the overrides won't be necessary in the future, as the eslint file feels a bit bloated already

Notes:

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[clairep94]

@khanniie @raclim ready for review! This can be reviewed before #3553 (migrate entire client/utils folder) if preferred as they're independent and this one is much smaller

[khanniie]

thank you!!

The merge-base changed after approval.

[clairep94]

@khanniie sorry I think this needs a re-review bc I updated the branch to match main!

Idk what that previous 'The merge-base changed after approval.' comment is, I think it's autogen from github when the base changes?