Migrated from JSHint to ESLint#3836
Open
Nishthajain7 wants to merge 1 commit intoprocessing:develop-codemirror-v6from
Open
Migrated from JSHint to ESLint#3836Nishthajain7 wants to merge 1 commit intoprocessing:develop-codemirror-v6from
Nishthajain7 wants to merge 1 commit intoprocessing:develop-codemirror-v6from
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
17 tasks
Member
|
Hi! Thank you so much for the contribution! If this is regarding the codemirror 5 to 6 migration, the subissue we published was actually regarding the js linter used within the Editor/stateUtils.js file. I do think the approach is correct, it would be great if you could move the changes to that file! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1540
Changes: Updated the preprocessing lint step to use ESLint instead of JSHint.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123