Fix MongoDB config and remove unnecessary DB dependency from preview server#3858
Open
sid2487 wants to merge 2 commits intoprocessing:developfrom
Open
Fix MongoDB config and remove unnecessary DB dependency from preview server#3858sid2487 wants to merge 2 commits intoprocessing:developfrom
sid2487 wants to merge 2 commits intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Contributor
|
Hey I tested and it works out, but doesn't changing the cookie lifetime affect the editor itself? |
Contributor
Author
The cookie maxAge remains unchanged (4 weeks), so session duration and editor behavior are unaffected. I removed the explicit ttl option from MongoStore.create() because connect-mongo automatically derives TTL from the session cookie's maxAge. This avoids redundant configuration while keeping the same session lifetime behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes MongoDB configuration inconsistencies and removes an unnecessary
database dependency from the preview server.
Changes
MONGO_URIMONGO_URL.env.examplewith actual runtime expectationsWhy
On a fresh local setup, the preview server attempted to connect to MongoDB using
credentials that may not exist, causing the application to crash. The preview
server does not require database access, so removing this dependency simplifies
local development and prevents startup crashes.
Testing