Open
Conversation
Collaborator
|
Tagging @runningonsideprojects and @Izzy-Snyder for review whenever you have a moment! |
Contributor
sorry it took so long to respond, will be reviewing later tonight! thank you for your patience @raclim @NishulDhakar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3856
Summary
This PR improves the Storage Bar color contrast across all themes (Light, Dark, and Contrast) to meet WCAG 2.1 Level AA non-text contrast requirements (minimum 3:1 ratio).
Problem: The Storage Bar on the Assets page had insufficient contrast (~1.1:1) between the progress indicator (
$P5-pink) and its background ($gray), creating accessibility barriers for visually impaired users.Solution: Updated theme variables and styling to increase contrast between the progress bar and background, and added a visible border that contrasts with the page background.
Changes Made
Variable Updates (
variables.scss)Light Theme:
progress-bar-background-colorfrom$grayto$lightprogress-bar-border-colorset to$middle-grayDark Theme:
progress-bar-background-colorfrom$grayto$darkerprogress-bar-border-colorset to$middle-grayContrast Theme:
progress-bar-background-colorfrom$grayto$darkerprogress-bar-active-colorfrom$P5-pinkto$yellowprogress-bar-border-colorset to$middle-lightStyling Updates (
_asset-size.scss)progress-bar-border-colorborder-color: getThemifyVariable('progress-bar-border-color')within the@include themify()blockQA Steps
https://editor.p5js.org/{username}/assetsScreenshots
Before
Light Theme:

Dark Theme:

Contrast Theme:

After
Light Theme:

Dark Theme:

Contrast Theme:
