Skip to content

Comments

Fix/storage bar contrast#3863

Open
NishulDhakar wants to merge 3 commits intoprocessing:developfrom
NishulDhakar:fix/storage-bar-contrast
Open

Fix/storage bar contrast#3863
NishulDhakar wants to merge 3 commits intoprocessing:developfrom
NishulDhakar:fix/storage-bar-contrast

Conversation

@NishulDhakar
Copy link

@NishulDhakar NishulDhakar commented Feb 12, 2026

Closes #3856

Summary

This PR improves the Storage Bar color contrast across all themes (Light, Dark, and Contrast) to meet WCAG 2.1 Level AA non-text contrast requirements (minimum 3:1 ratio).

Problem: The Storage Bar on the Assets page had insufficient contrast (~1.1:1) between the progress indicator ($P5-pink) and its background ($gray), creating accessibility barriers for visually impaired users.

Solution: Updated theme variables and styling to increase contrast between the progress bar and background, and added a visible border that contrasts with the page background.

Changes Made

Variable Updates (variables.scss)

Light Theme:

  • Changed progress-bar-background-color from $gray to $light
  • Added progress-bar-border-color set to $middle-gray

Dark Theme:

  • Changed progress-bar-background-color from $gray to $darker
  • Added progress-bar-border-color set to $middle-gray

Contrast Theme:

  • Changed progress-bar-background-color from $gray to $darker
  • Changed progress-bar-active-color from $P5-pink to $yellow
  • Added progress-bar-border-color set to $middle-light

Styling Updates (_asset-size.scss)

  • Replaced transparent border with theme-based progress-bar-border-color
  • Added border-color: getThemifyVariable('progress-bar-border-color') within the @include themify() block

QA Steps

  1. Set up local development environment with AWS S3 configuration.
  2. Start the local server and log in
  3. Navigate to https://editor.p5js.org/{username}/assets
  4. Upload one or more assets to trigger the Storage Bar display
  5. Switch between Light, Dark, and Contrast themes using the theme selector
  6. Verify:
    • Progress bar has clearly visible contrast against its background
    • Border is visible and provides additional distinction from page background
    • All three themes display correctly with improved accessibility

Screenshots

Before

Light Theme:
Screenshot 2026-02-12 at 8 31 20 PM

Dark Theme:
Screenshot 2026-02-12 at 8 42 08 PM

Contrast Theme:
Screenshot 2026-02-12 at 9 49 13 PM

After

Light Theme:
Screenshot 2026-02-12 at 8 31 08 PM

Dark Theme:
Screenshot 2026-02-12 at 9 47 40 PM

Contrast Theme:
Screenshot 2026-02-12 at 9 48 41 PM

@raclim
Copy link
Collaborator

raclim commented Feb 13, 2026

Tagging @runningonsideprojects and @Izzy-Snyder for review whenever you have a moment!

@runningonsideprojects
Copy link
Contributor

Tagging @runningonsideprojects and @Izzy-Snyder for review whenever you have a moment!

sorry it took so long to respond, will be reviewing later tonight! thank you for your patience @raclim @NishulDhakar

@raclim raclim added Area:Accessibility Category for accessibility related features and bugs Area:CSS For styling or layout issues handled with CSS/SASS labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area:Accessibility Category for accessibility related features and bugs Area:CSS For styling or layout issues handled with CSS/SASS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increasing color contrast of the Storage Bar on the Assets Page of the Profile Section

3 participants