Skip to content

fix: add missing aria-live to form error messages (#3874) #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raclim merged 11 commits into from
Feb 25, 2026
Merged

fix: add missing aria-live to form error messages (#3874) #3884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6524b1
fix: add aria-live='assertive' to LoginForm submit error (#3874)
Nixxx19 Feb 14, 2026
38e7dc0
fix: add aria-live='polite' to ResetPasswordForm field error
Nixxx19 Feb 14, 2026
d1b84e8
fix: add aria-live='polite' to AccountForm field errors
Nixxx19 Feb 14, 2026
ff60c34
fix: add aria-live='polite' to NewPasswordForm field errors
Nixxx19 Feb 14, 2026
0fb30b2
fix: add aria-live to CollectionCreate error spans
Nixxx19 Feb 14, 2026
19205f7
fix: add aria-live='polite' to NewFileForm field error
Nixxx19 Feb 14, 2026
fa461f6
fix: add aria-live='polite' to NewFolderForm field error
Nixxx19 Feb 14, 2026
a51f9c1
Merge branch 'develop' into nityam/fix-aria-live-login-error-#3874
Nixxx19 Feb 19, 2026
371a6e8
Merge branch 'develop' into nityam/fix-aria-live-login-error-#3874
Nixxx19 Feb 20, 2026
f7d7449
Merge branch 'develop' into nityam/fix-aria-live-login-error-#3874
Nixxx19 Feb 22, 2026
276b7f2
Merge branch 'develop' into nityam/fix-aria-live-login-error-#3874
raclim Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/modules/IDE/components/NewFileForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ function NewFileForm() {
</Field>
</div>
{touched.submitButton && errors.name && (
<span className="form-error">{errors.name}</span>
<span className="form-error" aria-live="polite">
{errors.name}
</span>
)}
</form>
)}
Expand Down
4 changes: 3 additions & 1 deletion client/modules/IDE/components/NewFolderForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ function NewFolderForm() {
</Field>
</div>
{touched.submitButton && errors.name && (
<span className="form-error">{errors.name}</span>
<span className="form-error" aria-live="polite">
{errors.name}
</span>
)}
</form>
)}
Expand Down
16 changes: 12 additions & 4 deletions client/modules/User/components/AccountForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ export function AccountForm() {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand Down Expand Up @@ -135,7 +137,9 @@ export function AccountForm() {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand All @@ -156,7 +160,9 @@ export function AccountForm() {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand All @@ -178,7 +184,9 @@ export function AccountForm() {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand Down
4 changes: 2 additions & 2 deletions client/modules/User/components/CollectionCreate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const CollectionCreate = () => {
<div className="sketches-table-container">
<form className="form" onSubmit={handleCreateCollection}>
{creationError && (
<span className="form-error">
<span className="form-error" aria-live="assertive">
{t('CollectionCreate.FormError')}
</span>
)}
Expand All @@ -55,7 +55,7 @@ const CollectionCreate = () => {
onChange={(e) => setName(e.target.value)}
/>
{invalid && (
<span className="form-error">
<span className="form-error" aria-live="polite">
{t('CollectionCreate.NameRequired')}
</span>
)}
Expand Down
2 changes: 1 addition & 1 deletion client/modules/User/components/LoginForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export function LoginForm() {
)}
</Field>
{submitError && !modifiedSinceLastSubmit && (
<span className="form-error">
<span className="form-error" aria-live="assertive">
{t('LoginForm.Errors.invalidCredentials')}
</span>
)}
Expand Down
8 changes: 6 additions & 2 deletions client/modules/User/components/NewPasswordForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ export function NewPasswordForm(props: { resetPasswordToken: string }) {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand All @@ -59,7 +61,9 @@ export function NewPasswordForm(props: { resetPasswordToken: string }) {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand Down
4 changes: 3 additions & 1 deletion client/modules/User/components/ResetPasswordForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ export function ResetPasswordForm() {
{...field.input}
/>
{field.meta.touched && field.meta.error && (
<span className="form-error">{field.meta.error}</span>
<span className="form-error" aria-live="polite">
{field.meta.error}
</span>
)}
</p>
)}
Expand Down