Skip to content

Comments

FIxing Visibility Updating Bug#3920

Open
Jatin24062005 wants to merge 1 commit intoprocessing:developfrom
Jatin24062005:Visibility_Map_Function_Error_Fix
Open

FIxing Visibility Updating Bug#3920
Jatin24062005 wants to merge 1 commit intoprocessing:developfrom
Jatin24062005:Visibility_Map_Function_Error_Fix

Conversation

@Jatin24062005
Copy link
Contributor

Issue:

Fixes #3864
CHANGE_VISIBILITY was attempting to call .map() on the sketches state object instead of the projects array, causing the reducer to error and preventing the UI from updating.

Demo:

image

Changes:

Updated the CHANGE_VISIBILITY case in the sketches reducer to:

  • Operate on state.projects instead of state
  • Return a new state object with an updated projects array

This ensures the Redux state slice that the Sketches list subscribes to actually changes.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sketch visibility change (Public/Private) does not update UI without manual refresh

1 participant