curveVertex shape not closing

[karenpeng]

Hi, i try to run this code:

noFill();
beginShape();
curveVertex(84,  91);
curveVertex(84,  91);
curveVertex(68,  19);
curveVertex(21,  17);
curveVertex(32, 100);
curveVertex(32, 100);
endShape();

But the shape is not closing, any idea why?

[hamoid]

Don't you need endShape(CLOSE); ?

[lmccart]

@hamoid indeed, but just tried with CLOSE in there and it still seems to not work. however this example does:

beginShape();
vertex(20, 20);
vertex(45, 20);
vertex(45, 80);
endShape(CLOSE);

so it must be some bug with curveVertex and closing paths.

[zaerl]

The curveVertex function collects vertices. Once it has 4 vertices the curve function is called which actually draw at screen the curve (with a beginShape - > endShape -> closePath -> stroke calls chain). Given this you can't call endShape(CLOSE) on a curve constructed in this way. It will never close cause it's already "closed."

[lmccart]

@zaerl yes, this is right... the shape/vertex stuff is in need of a redo in general. what we should be doing is collecting all the vertices and waiting until endShape to draw anything. this would also improve performance, in addition to make endShape arguments work correctly.

[bmoren]

This is still an error in 0.6.0
This will not close...

function setup() {
  // put setup code here
  createCanvas(600,600)
  curvyPolygon(10,100,100,100)
}

function curvyPolygon( n, xPOS, yPOS, r) {
  let angle = 360.0 / n;

  beginShape();
  for (let i = 0; i < n; i++) {
    curveVertex(xPOS + r  * cos(radians(angle * i)),
      yPOS + r   * sin(radians(angle * i)));
  }

  endShape(CLOSE);

}