Change mouseX/mouseY handling#1471
Merged
lmccart merged 1 commit intoprocessing:masterfrom Jun 17, 2016
Merged
Conversation
Member
|
this is great and makes a lot of sense, thank you! |
islemaster
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Nov 9, 2016
The collision update brings with it a p5 version update - we're now on p5.js 0.5.4. It turns out in [0.5.2](https://github.com/processing/p5.js/releases/tag/0.5.2) a [change to how `mouseX`/`mouseY` are tracked and updated](processing/p5.js#1471) was introduced. That's code we'd monkeypatched over to scale mouse coordinates with our resizable playspace. This updates the monkeypatches (for both mouse and touch coordinates) to match the code in p5.js 0.5.4, but keeps our scaling modification intact.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This changes the way mouse and touch values are stored to address the following two tickets:
#1176
#1269
Currently,
mouseXandmouseYvalues are always lagging behind the real system values when the mouse is moving.The new approach works like this:
mouseXandmouseYvalues so that they represent the actual mouse value at that eventdraw()a frame, we set thepmouseXandpmouseYto the value ofmouseXandmouseY, the next time the draw is called it will have the previous mouse positionmouseXandmouseY, we also set thepmouseX/pmouseYto the same value. This way they don't start at (0, 0) which is a bit arbitrary.pwinMouseX/pwinMouseYSome tests, I'm using the p5js editor.
Example 1
Before PR:

After PR:

Example 2
Before PR:

After PR:

Let me know what you think! 😄