Converted docs/documented-method.js to ES6#3881
Merged
lmccart merged 2 commits intoprocessing:masterfrom Jul 11, 2019
abhinavsagar:patch-7
Merged
Converted docs/documented-method.js to ES6#3881lmccart merged 2 commits intoprocessing:masterfrom abhinavsagar:patch-7
lmccart merged 2 commits intoprocessing:masterfrom
abhinavsagar:patch-7
Conversation
Contributor
Author
|
@stalgiag Should the codebase itself be converted to ES6 ? |
Contributor
|
Hi @abhinavsagar thanks for the offer but most of this conversion was handled by #3874. That said there will likely be further slight modifications that might need help. Feel free to follow open issues such as #3877 and #3875 to see if there are any new todos about ES6 conversion. |
Contributor
|
I think that #3877 in particular is relevant to this particular PR. Definitely the change from |
Contributor
Author
|
Thanks. I will go through the open issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3758