use let in examples#4017
Merged
outofambit merged 5 commits intoprocessing:masterfrom Sep 16, 2019
LisaMabley:issue-3877-use-let-in-examples
Merged
use let in examples#4017outofambit merged 5 commits intoprocessing:masterfrom LisaMabley:issue-3877-use-let-in-examples
outofambit merged 5 commits intoprocessing:masterfrom
LisaMabley:issue-3877-use-let-in-examples
Conversation
added 2 commits
September 15, 2019 11:46
…ion for future contributors to use let going forward.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
added 2 commits
September 15, 2019 13:58
outofambit
approved these changes
Sep 16, 2019
Contributor
outofambit
left a comment
outofambit
left a comment
There was a problem hiding this comment.
looks great, thank you @LisaMabley ! i pushed a quick fix for a const we need to keep cause its actually in some shader code.
unfortunately the changes to p5.sound.js will most likely be lost when we update the sound addon (as in #3988), so we'll need to make those changes in https://github.com/processing/p5.js-sound too. @therewasaguy and @lmccart does that sound right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First two files updated.
closes #3877