Skip to content

Comments

Fix black first frame when rendering gifs in setup#6081

Merged
Qianqianye merged 1 commit intoprocessing:mainfrom
davepagurek:fix/gif-setup
Mar 22, 2023
Merged

Fix black first frame when rendering gifs in setup#6081
Qianqianye merged 1 commit intoprocessing:mainfrom
davepagurek:fix/gif-setup

Conversation

@davepagurek
Copy link
Contributor

Resolves #6080

Changes

  • Previously, the first frame of a gif rendered in setup would be black
  • This looks like it's because we hide canvases until setup finishes, and that seems to be affecting our ability to grab pixels
  • Awaits an immediately-resolving promise before starting to render frames defers execution so that setup completes before we pick back up again

Screenshots of the change

Before: the downloaded gif starts on a black frame

After: the first frame has content!
image

Working gif, for reference:

mySketch(11)

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gifs exported from saveGif in setup start with a black frame

2 participants