Skip to content

Ask to disable printing when print() called with no arguments #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limzykenneth merged 1 commit into from
Jul 12, 2023
Merged

Ask to disable printing when print() called with no arguments #6253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/core/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ p5.prototype._lastFrameTime = window.performance.now();
p5.prototype._targetFrameRate = 60;

const _windowPrint = window.print;
let windowPrintDisabled = false;

/**
* The <a href="#/p5/print">print()</a> function writes to the console area of
Expand Down Expand Up @@ -43,7 +44,16 @@ const _windowPrint = window.print;
*/
p5.prototype.print = function(...args) {
if (!args.length) {
_windowPrint();
if (!windowPrintDisabled) {
_windowPrint();
if (
window.confirm(
'You just tried to print the webpage. Do you want to prevent this from running again?'
)
) {
windowPrintDisabled = true;
}
}
} else {
console.log(...args);
}
Expand Down