fix camera slerp() BUG#6509
Merged
davepagurek merged 3 commits intoprocessing:mainfrom Oct 30, 2023
inaridarkfox4231:fix_slerpBUG
Merged
fix camera slerp() BUG#6509davepagurek merged 3 commits intoprocessing:mainfrom inaridarkfox4231:fix_slerpBUG
davepagurek merged 3 commits intoprocessing:mainfrom
inaridarkfox4231:fix_slerpBUG
Conversation
fix column() to row()
Contributor
Author
|
Since the unit test did not detect this bug, we will add one unit test to prevent this from happening in the future. |
Add more unit tests to prevent bugs caused by changes to slerp().
Contributor
Author
|
That's all. |
Remove unnecessary line breaks
Contributor
Author
|
I thought that for some reason there was a mismatch regarding line breaks, but it seems I was mistaken. |
davepagurek
approved these changes
Oct 30, 2023
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for the fix + the test case for preventing future regressions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix column() to row().
Resolves #6508
Changes:
A bug occurred in camera's slerp() due to a change in the specifications of column() and row().
So I'll fix that.
CAMERA_SLERP_BUG
before
after
PR Checklist
npm run lintpasses