Skip to content

Comments

Fix width/height not matching after get()#6542

Merged
limzykenneth merged 1 commit intoprocessing:mainfrom
davepagurek:fix/img-pixel-density
Nov 24, 2023
Merged

Fix width/height not matching after get()#6542
limzykenneth merged 1 commit intoprocessing:mainfrom
davepagurek:fix/img-pixel-density

Conversation

@davepagurek
Copy link
Contributor

Resolves #6540

Changes

  • Calls pixelDensity() on images created via get() rather than setting an internal property

Screenshots of the change

https://editor.p5js.org/davepagurek/sketches/6VuOKHnPv

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@Qianqianye Qianqianye added this to the 1.9.0 milestone Nov 23, 2023
@Qianqianye Qianqianye mentioned this pull request Nov 23, 2023
7 tasks
@limzykenneth limzykenneth merged commit a5fa292 into processing:main Nov 24, 2023
@limzykenneth
Copy link
Member

Looks good. Thanks!

@davepagurek davepagurek deleted the fix/img-pixel-density branch November 24, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get(x, y, w, h) output image width/height is doubled

3 participants