Fixed example broken by #6216 and added information for new camera default setting#6620
Merged
davepagurek merged 10 commits intoprocessing:mainfrom Dec 15, 2023
inaridarkfox4231:fix-the-camera-reference-bug
Merged
Fixed example broken by #6216 and added information for new camera default setting#6620davepagurek merged 10 commits intoprocessing:mainfrom inaridarkfox4231:fix-the-camera-reference-bug
davepagurek merged 10 commits intoprocessing:mainfrom
inaridarkfox4231:fix-the-camera-reference-bug
Conversation
Restore camera settings according to 100x100
Restore camera settings according to 100x100
Regarding the setCamera() example, the transition was not clean, so I modified the code.
It looks like a parallel projection, so I'll fix it.
The way I set the background was sloppy, so I fixed it.
camera(0, 0, 50*sqrt(3), 0, 0, 0, 0, 1, 0); perspective(PI/3, 1, 5*sqrt(3), 500*sqrt(3));
add information about new 80,800,8000 camera default system.
fix indent
The image() function uses push() to pop() internally, so the processing is duplicated and it's not pretty. Also, since it may be affected by imageMode(), I thought this would be better.
add noLights()
Contributor
Author
|
Please leave a review. |
davepagurek
approved these changes
Dec 15, 2023
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for combing through all the examples!
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #6216, many reference examples related to cameras were broken. The purpose is to restore it to its original state.
Resolves #6611
Changes: many.
Screenshots of the change:
before
after
PR Checklist
npm run lintpasses