Closed
Conversation
Fix for issue 7259 to check for negative locX and locY in gridOutput.js
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Member
|
Hi @himanshuukholiya I saw you were active on the related issue here #7259, can you check if this is still relevant? The issue seems to be marked as resolved. Thanks! |
Contributor
Member
|
Thanks @himanshuukholiya . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7259
Changes:
Some shapes located outside of the canvas and the current check in _gridMap only applies to positive locX and locY but not negative values. The fix is to check for negative values and hence avoiding a negative indexing to an array which causes the issue.
Screenshots of the change:
PR Checklist
npm run lintpasses