[p5.js 2.x] chore: enable pre-commit hooks#7933
[p5.js 2.x] chore: enable pre-commit hooks#7933error-four-o-four wants to merge 2 commits intoprocessing:dev-2.0from
pre-commit hooks#7933Conversation
error-four-o-four
changed the title
pre-commit hookspre-commit hooks
ksen0
left a comment
ksen0
left a comment
There was a problem hiding this comment.
Thanks for working on this @error-four-o-four , sorry for delay in review. Only 1 minor comment re:authorship. Tagging also other DevOps stewards: @Vaivaswat2244 @limzykenneth @lirenjie95
| }, | ||
| "repository": "processing/p5.js", | ||
| "license": "LGPL-2.1", | ||
| "author": "", |
There was a problem hiding this comment.
As far as I understand, the "author" field is a best practice to include but optional. Because this project follows the All Contributors specification, I think it could either be omitted or using something like "p5.js contributors"? Any thoughts on this? Minor preference against adding this as a blank field.
There was a problem hiding this comment.
The author field here is not quite added but just rearranged from elsewhere in this file, ie. it is there already before as a blank string. I'm not sure this field is read by anything specific (that I know of) to populate something so I think something like "p5.js contributors" is fine either way.
There was a problem hiding this comment.
Ah Ok I saw other rearranged fields but missed this one. Sorry!
3 participants
adresses #7930
This PR enables the pre-commit hooks to make use of
lint-staged.As a one time fix this PR uses
npx sort-package-jsonto sort the fields in the package.json.