[dev-2.0] style: fix eslint warnings#8055
[dev-2.0] style: fix eslint warnings#8055sevenc-nanashi wants to merge 5 commits intoprocessing:dev-2.0from
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
| } | ||
| let output = '// This file is auto-generated from JSDoc documentation\n\n'; | ||
|
|
||
| output += 'declare class p5 {\n'; |
There was a problem hiding this comment.
The quotes rule looks too aggressive...
I think it's okay to allow backticks in any case.
| [ | ||
| "Function", | ||
| "Object?" | ||
| ], |
There was a problem hiding this comment.
parameterData.json might be out of date. I think it's nice to have a CI that checks parameterData.json is up-to-date.
| const processOverload = overload => { | ||
| if (overload.params) { | ||
| return Object.values(overload.params).map(param => processParam(param)); | ||
| } | ||
| return overload; | ||
| }; |
There was a problem hiding this comment.
ESLint warned that processOverload comes before processParam, thus it might call uninitialized variable. This is why I moved this code.
sevenc-nanashi
changed the title
|
I feel like this pr is too old to merge, so I'm closing this |
1 participant
Relates #7930 (Maybe?)
Changes:
I fixed ESLint warnings in
utils/**/*.mjs.casebranch which defines variableScreenshots of the change:
N/A
PR Checklist
npm run lintpasses