Create 'Effect.js' Superclass

[ogbabydiesal]

derived classes would include effects such as Delay, Reverb, etc..

the benefit of this is that we can inherit methods such as wetdry() and amp()

[lvdopqt]

Hello again
I've started this change in this branch. I've created an effects folder and changed the import reference in the app entrypoint. For now I've just moved the connect/disconnect functions to this Effect.js superclass, but maybe it could be moved to a more generic "Node" superclass.
I didnt implement wetdry() and amp() or other functions for now, but the structure is ~ready for that.

[ogbabydiesal]

hi @lvdopqt incredible - just seeing this now unfortunately - i'll check out this branch
agree with you on the "Node" superclass - just got off the phone with @pparocza about contributing and we were discussing something simillar -

a "node" superclass might have

• connect/disconnect
• amp
• pan(?) (maybe not as this would eliminate the need for the panner class)

[pparocza]

thanks for the mention @ogbabydiesal !

@lvdopqt awesome work! would it be possible for you to put these changes on a branch from the main p5.sound repo instead of from your own fork? will make it a bit easier to review and keep track of changes

[ogbabydiesal]

here is the original p5.sound.js 'effect' class for reference
https://archive.p5js.org/reference/#/p5.Effect

the new effect class might have amp(), drywet(), connect(), disconnect()

[pparocza]

Handled in PR #59 by P5SoundEffectNode.