Open
Conversation
ec10d68 to
14ecafc
Compare
- Add GitHub Actions workflow testing Ruby 2.7, 3.0, 3.1, 3.2, 3.3 - Remove outdated Travis CI config (was testing Ruby 2.3-2.5) - Update README badge Ruby 3.3 compatibility fixes: - Update rubocop from 0.71.0 to ~> 1.68 (0.71.0 incompatible with Ruby 3.3) - Simplify .rubocop.yml - Rails and Performance cops were extracted to separate gems (rubocop-rails, rubocop-performance) in RuboCop 0.72. Since sift doesn't need those cops, removed them instead of adding the extra dependencies. - Add `require "ostruct"` in test_helper (ostruct moved to gem in Ruby 3.2+) - Pin minitest to ~> 5.0 for Rails 7.x appraisals (minitest 6.0 has breaking API changes incompatible with Rails test runner) - Pin sqlite3 to ~> 1.4 for Rails 7.0/7.1 (Rails 7.0 requires sqlite3 < 2) Rails version updates: - Drop Rails 6.1 (end of life, no longer receiving security fixes) - Add Rails 7.1, 7.2, 8.0 appraisals - Update activerecord dependency to >= 7.0
14ecafc to
12a983a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sonarqube_analysischeckRuby 3.3 compatibility fixes
rubocop-rails,rubocop-performance) starting in RuboCop 0.72 (2019). Since sift doesn't need those cops, I removed them rather than adding extra dependencies.require "ostruct"in test_helper -ostructwas moved from stdlib to a gem in Ruby 3.2+Rails version updates
Test plan