feat(tb-pr): hide drafts in waiting-on-me/author by default, Shift+D toggle#31
Merged
Conversation
…toggle GitHub's `user-review-requested:@me` search keeps PRs in the list even after the author converts them back to draft, so reviewers see WIP cards they shouldn't be acting on yet. Hide drafts from `waiting_on_me` and `waiting_on_author` by default, and bind Shift+D to toggle them back on per session. `DraftMine` is unaffected — it exists for drafts. Column title shows `(N, K draft hidden)` and the footer surfaces the current toggle state so the filter isn't silent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ndler Strip multi-line doc comments off `hide_drafts` and `hidden_draft_count` to match the existing `full_titles` / `help_open` style (no docs on simple state). Keep one short comment on `visible_prs` for the WHY of not filtering `DraftMine`. Rework the clamp test to flip the filter via the `D` key handler instead of writing to the field directly, so the test exercises the public surface end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Filter sam postavio da je defaultno ukljucen 
Kad ga se iskljuci (Vracanje u staro ponasanje) 
|
ilucin
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user-review-requested:@mesearch keeps a PR in the result set even after the author converts it back to draft, so reviewers were seeing WIP cards they shouldn't act on yet. Discussed in Slack with @ilucin — drafts get filtered, with a session toggle.PrState::DraftfromWaiting-on-meandWaiting-on-authorby default.DraftMineis unaffected (it exists for drafts).D=show-drafts/D=hide-drafts), column title shows(N, K draft hidden)so the filter isn't invisible.Implementation
App.hide_drafts: bool(defaults totrue).App::visible_prs(col)andApp::hidden_draft_count(col)filter on the fly — onlyWaitingOnMe/WaitingOnAuthorare touched.selected_prnow go throughvisible_prs.Test plan
cargo test --workspace— all green (new tests: filter scope, key toggle resets scroll, clamping after toggling filter on).cargo clippy --workspace -- -D warningscargo fmt --checktb-pr tuiand verify: a draft PR inWaiting-on-meis hidden by default, column shows(N, 1 draft hidden), Shift+D toggles visibility, footer label flips.Slack context: thread in DM with @ilucin (2026-05-08 → 2026-05-11). Default chosen "hidden" to fix the originally reported behavior out of the box.