Merged
Conversation
Coverage Report
Summary
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
5 tasks
grigoriev-semyon
requested changes
May 15, 2023
Member
|
По моему ты там нагородил функцию из асбстракций который можно сломать когда количество уникальных записей в «1,2,3,…» больше чем количество страниц |
dyakovri
reviewed
May 15, 2023
Member
dyakovri
left a comment
There was a problem hiding this comment.
А можешь еще создать errors.py и error_handlers по аналогии с аутхом?
В первый поместить ошибки, которые будут обычными питонячими
Типа TooLargeSize, TooManyPages, InvalidFormat и и.д.
А во второй поместить обработчики этих ошибок, которые будут отдавать JSON с ошибкой и нужным статус кодом
dyakovri
reviewed
May 15, 2023
grigoriev-semyon
requested changes
May 21, 2023
5 tasks
5 tasks
5 tasks
grigoriev-semyon
requested changes
May 21, 2023
Member
grigoriev-semyon
left a comment
There was a problem hiding this comment.
Не исправлено ничего из моего ревью
|
💩 Code linting failed, use |
grigoriev-semyon
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
В настройках можно указать ограничение на количество листов, которые можно распечатать на принтере.
Реализации
Детали
Check-List
P.S. Проставьте x в квадратные скобки в нужных пунктах. Example: [x]