Merged
Conversation
5 tasks
Coverage Report
Summary
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Wudext
previously requested changes
Jul 26, 2023
Wudext
left a comment
There was a problem hiding this comment.
У тебя при мердже в main может возникнуть проблема с тем, что у существующих записей нет параметра source (который у тебя not null) и ты уронишь тест (или прод). Алембик в этом плане тупенткий, поэтому либо в моделе БД в срочке где добавлен source пиши default='что-то', либо прописывай руками в миграции задание нужных значений (что ой как не весело).
|
💩 Code linting failed, use |
5 tasks
grigoriev-semyon
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
При отправке файла на печать теперь также указывается источник отправки.
Реализации
Добавлен параметр source в POST-ручке /file, а также добавлена строчка в БД.
Детали
В JSON-модель добавлен string-параметр source, а также в БД File добавлено поле source.
Check-List