Skip to content

Защита ручки GET /file/{pin}#86

Merged
Temmmmmo merged 2 commits intomainfrom
40-защитить-ручки-get-filepin-get-staticfilepdf
Oct 23, 2024

Hidden character warning

The head ref may contain hidden characters: "40-\u0437\u0430\u0449\u0438\u0442\u0438\u0442\u044c-\u0440\u0443\u0447\u043a\u0438-get-filepin-get-staticfilepdf"
Merged

Защита ручки GET /file/{pin}#86
Temmmmmo merged 2 commits intomainfrom
40-защитить-ручки-get-filepin-get-staticfilepdf

Conversation

@gitfresnel
Copy link
Copy Markdown
Contributor

Изменения

добавил авторизацию ручки GET /file/{pin}

@gitfresnel gitfresnel linked an issue Sep 2, 2024 that may be closed by this pull request
3 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
print_service
   __main__.py440%1–7
   base.py12467%6–9
   exceptions.py52787%21, 40, 45, 60, 65, 70, 77
print_service/routes
   admin.py492647%28–29, 32–36, 39–43, 50–56, 63–69
   auth.py440%1–8
   exc_handlers.py59985%34, 58, 70, 80, 124, 136, 144, 154, 166
   file.py1311985%50, 56, 58, 130–131, 175, 183–184, 186, 189–190, 195–196, 206–209, 254, 263
   qrprint.py1127137%39–48, 53–59, 62–70, 73–82, 86–107, 110, 113–116, 124–127, 135–148
   user.py51492%66, 114–116
print_service/utils
   __init__.py58395%44, 86–87
TOTAL65515177% 

Summary

Tests Skipped Failures Errors Time
23 1 💤 0 ❌ 0 🔥 1.084s ⏱️

@Temmmmmo Temmmmmo changed the title f Защита ручки GET /file/{pin} Sep 19, 2024
@Temmmmmo
Copy link
Copy Markdown
Member

Нужно защитить не только GET /file/{pin}, а защитить еще следующие ручки:

POST /file/{pin} Scope: print.file.create
PATCH /file/{pin} Scope: print.file.update

@Temmmmmo Temmmmmo merged commit 909ca5a into main Oct 23, 2024
@Temmmmmo Temmmmmo deleted the 40-защитить-ручки-get-filepin-get-staticfilepdf branch October 23, 2024 13:16
MarkShidran added a commit that referenced this pull request Dec 27, 2024
MarkShidran added a commit that referenced this pull request Dec 27, 2024
Откатываем, чтобы спасти прод. Потом вернем @Temmmmmo 

Reverts #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Защитить ручки GET /file/{pin}, GET /static/{file}.pdf

2 participants