Conversation
|
💩 Code linting failed, use |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Summary
|
|
💩 Code linting failed, use |
Temmmmmo
requested changes
Apr 1, 2025
Comment on lines
+310
to
+311
| if not has_delete_scope: | ||
| if comment.is_anonymous: |
Member
There was a problem hiding this comment.
if not has_delete_scope and comment.is_anonymous:
raise ForbiddenAction(Comment)
| if comment.is_anonymous: | ||
| raise ForbiddenAction(Comment) | ||
|
|
||
| if not has_delete_scope or comment.user_id != user.id: |
Member
There was a problem hiding this comment.
Если нет права на удаление, то удалить можно только свой неанонимный комментарий
т.е.
если нет права на удаление и коммент анонимный или не твой то рейзим ошибку
if not has_delete_scope and (comment.is_anonymous or comment.user_id != user.id):
raise ...
Member
There was a problem hiding this comment.
в целом одного этого условия хватит
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?