Skip to content

Pivo.advanced sort#121

Merged
Zimovchik merged 9 commits intomainfrom
pivo.advancedSort
May 3, 2025
Merged

Pivo.advanced sort#121
Zimovchik merged 9 commits intomainfrom
pivo.advancedSort

Conversation

@MikhailPI1
Copy link
Copy Markdown
Contributor

@MikhailPI1 MikhailPI1 commented Apr 15, 2025

Изменения

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2025

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py43784%35–37, 48–50, 58
rating_api/models
   base.py64592%24–27, 94
   db.py102496%61, 75, 84, 134
rating_api/routes
   base.py16194%41
   comment.py1113073%65, 83, 124–126, 147–156, 220–221, 223–224, 232–237, 264, 277, 304–315
   exc_handlers.py32391%36, 43, 50
   lecturer.py891682%136, 141–167, 183, 191, 209, 215
rating_api/schemas
   base.py12467%6–9
   models.py138398%102–104
TOTAL6537788% 

Summary

Tests Skipped Failures Errors Time
51 0 💤 0 ❌ 0 🔥 10.908s ⏱️

@MikhailPI1 MikhailPI1 requested a review from zipperman1 April 15, 2025 19:53
@MikhailPI1 MikhailPI1 linked an issue Apr 15, 2025 that may be closed by this pull request
@zipperman1 zipperman1 requested a review from Zimovchik April 15, 2025 19:58
@Zimovchik
Copy link
Copy Markdown
Member

я хочу чтобы это делала алхимия а не питоновский сорт, посмотри как сделано для лекторов.

Comment thread rating_api/routes/comment.py Outdated
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

Comment thread rating_api/routes/comment.py
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

Comment thread rating_api/models/db.py Outdated
Comment thread rating_api/models/db.py Outdated
Comment thread rating_api/models/db.py Outdated
@MikhailPI1
Copy link
Copy Markdown
Contributor Author

Я сделал исправления согласны указаниям, но это не решило проблемы с пустыми значениями Lecturer_id и user_id одновременно, он по-прежнему выдает 500 ошибку и я не могу понять чем она вызвана. Можно ли получить совет как это исправить

Comment thread rating_api/models/db.py
Comment thread rating_api/models/db.py
Comment thread rating_api/routes/comment.py
Copy link
Copy Markdown
Member

@Zimovchik Zimovchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и убери все принты из кода

Comment thread tests/conftest.py Outdated
@Zimovchik Zimovchik merged commit e19e434 into main May 3, 2025
2 checks passed
@Zimovchik Zimovchik deleted the pivo.advancedSort branch May 3, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Продвинутая сортировка комментариев

3 participants