Merged
Conversation
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull Request Overview
This PR adds a “subject” filter to the comments endpoint, allowing requests to filter comments by subject, while also modifying the behavior of existing lecturer-based filtering.
- Added an optional “subject” query parameter in the get_comments route.
- Introduced a new search_by_subject method in the Comment model.
- Updated search_by_lectorer_id to remove the review status condition.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rating_api/routes/comment.py | Added subject parameter and applied subject filter in the route |
| rating_api/models/db.py | Added search_by_subject method and modified search_by_lectorer_id behavior |
Comments suppressed due to low confidence (1)
rating_api/models/db.py:140
- The change in search_by_lectorer_id removes the filtering by ReviewStatus.APPROVED, which may result in unexpected behavior. Please verify if this change is intentional or if the condition should be retained to ensure only approved comments are returned.
return Comment.lecturer_id == query
| def search_by_subject(self, query: str) -> bool: | ||
| if not query: | ||
| return true() | ||
| return func.lower(Comment.subject).contains(query) |
There was a problem hiding this comment.
[nitpick] Consider converting the query parameter to lower case before performing the contains operation for a consistent case-insensitive comparison.
Suggested change
| return func.lower(Comment.subject).contains(query) | |
| return func.lower(Comment.subject).contains(query.lower()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?