Skip to content

Ограничения на поля оценок#29

Merged
Temmmmmo merged 2 commits intomainfrom
26-добавить-ограничение-на-поля-оценок
Nov 7, 2024

Hidden character warning

The head ref may contain hidden characters: "26-\u0434\u043e\u0431\u0430\u0432\u0438\u0442\u044c-\u043e\u0433\u0440\u0430\u043d\u0438\u0447\u0435\u043d\u0438\u0435-\u043d\u0430-\u043f\u043e\u043b\u044f-\u043e\u0446\u0435\u043d\u043e\u043a"
Merged

Ограничения на поля оценок#29
Temmmmmo merged 2 commits intomainfrom
26-добавить-ограничение-на-поля-оценок

Conversation

@gitfresnel
Copy link
Copy Markdown
Contributor

Изменения

Добавил ограничения для полей оценок

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@gitfresnel gitfresnel linked an issue Nov 2, 2024 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 2, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26388%35–36, 44
rating_api/models
   base.py55787%24–27, 45, 53, 74
rating_api/routes
   comment.py662858%28, 34–37, 85–108, 125–128, 142
   exc_handlers.py20290%26, 33
   lecturer.py883165%55, 104–145, 159, 167, 185, 191
rating_api/schemas
   base.py12467%6–9
TOTAL4167981% 

Summary

Tests Skipped Failures Errors Time
9 0 💤 0 ❌ 0 🔥 0.768s ⏱️

Comment thread rating_api/schemas/models.py Outdated
@classmethod
def validate_mark(cls, value):
if value not in [-2, -1, 0, 1, 2]:
raise ValueError('оценка может принимать только значения: -2, -1, 0, 1, 2')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай свой exception создадим и handler к нему

@Temmmmmo Temmmmmo merged commit cd8370b into main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Добавить ограничение на поля оценок

2 participants