Skip to content

Soft deletes final fix + tests#41

Merged
Temmmmmo merged 6 commits intomainfrom
soft-deletes1
Nov 10, 2024
Merged

Soft deletes final fix + tests#41
Temmmmmo merged 6 commits intomainfrom
soft-deletes1

Conversation

@Zimovchik
Copy link
Copy Markdown
Member

Изменения

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 10, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26388%35–36, 44
rating_api/models
   base.py55591%24–27, 76
   db.py62592%51–55
rating_api/routes
   comment.py662858%28, 34–37, 85–108, 125–128, 142
   exc_handlers.py20290%26, 33
   lecturer.py901880%52, 106, 116–140, 143, 158, 166, 184, 190
rating_api/schemas
   base.py12467%6–9
TOTAL4386984% 

Summary

Tests Skipped Failures Errors Time
10 0 💤 0 ❌ 0 🔥 0.898s ⏱️

@Zimovchik
Copy link
Copy Markdown
Member Author

Zimovchik commented Nov 10, 2024

#22 прошлый пр

@Zimovchik Zimovchik linked an issue Nov 10, 2024 that may be closed by this pull request
@Zimovchik Zimovchik self-assigned this Nov 10, 2024
@Zimovchik
Copy link
Copy Markdown
Member Author

миграция не конфликтит если есть прошлые записи, само вставит is_deleted = False

@Temmmmmo Temmmmmo merged commit c3378e8 into main Nov 10, 2024
@Zimovchik Zimovchik deleted the soft-deletes1 branch November 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Добавить soft-deletes в рейтинг

2 participants