Conversation
Temmmmmo
reviewed
Nov 10, 2024
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Wudext
reviewed
Nov 11, 2024
Temmmmmo
reviewed
Nov 14, 2024
Wudext
reviewed
Nov 18, 2024
Contributor
Wudext
left a comment
There was a problem hiding this comment.
Я бы подумал над изменением логики высчитывания среднего, потому что сейчас идет итерирование трижды по всем оценкам лектора, т.е. get запросы в будущем с такой логикой будут тормозить
В целом ок, по этому просто коммент
Closed
2 tasks
Temmmmmo
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Изменено поведение сортировки лекторов
Детали реализации
Сортировка теперь происходит либо по средней оценке (стандартное), либо по отдельному виду оценки, либо по алфавиту фамилий.
Появилась возможность менять порядок сортировки (ascending/descending order)
Также исправлен баг с сортировкой только limit-первых лекторов, а не всех
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?