added create_ts and update_ts to create_comment#50

Merged

Temmmmmo merged 25 commits intomainfrom

Nov 24, 2024

Contributor

zipperman1 commented Nov 15, 2024 •

edited

Loading

Изменения

добавлена возможность указать время создания и изменения комментария для админов

Детали реализации

проверка на скоуп rating.comment.review
заменяем None на utcnow если дата на указана
скипаем проверку времени если у автора есть скоуп

Check-List

Вы проверили свой код перед отправкой запроса?
Вы написали тесты к реализованным функциям?
Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?


          added create_ts and update_ts to create_comment

8c1a8ba

github-actions Bot commented Nov 15, 2024 •

edited

Loading

Coverage Report

File	Stmts	Miss	Cover	Missing
rating_api
__main__.py	4	4	0%	1–7
exceptions.py	26	2	92%	35–36
rating_api/models
base.py	55	1	98%	76
db.py	73	2	97%	61, 74
rating_api/routes
comment.py	73	12	84%	31, 42–45, 108, 118–123, 130, 153, 169
exc_handlers.py	20	1	95%	26
lecturer.py	84	14	83%	132–153, 169, 177, 195, 201
rating_api/schemas
base.py	12	4	67%	6–9
TOTAL	454	40	91%

Summary

Tests	Skipped	Failures	Errors	Time
44	0 💤	3 ❌	0 🔥	3.048s ⏱️

Zimovchik requested changes

View reviewed changes

Member

Zimovchik left a comment

надо потестить локально + дописать тесты

rating_api/routes/comment.py Outdated

rating_api/routes/comment.py Outdated

rating_api/routes/comment.py Outdated

rating_api/routes/comment.py Outdated

zipperman1 linked an issue

that may be closed by this pull request

Выгрузка данных из дубинушки #21

Closed

zipperman1 self-assigned this

Zimovchik reviewed

View reviewed changes

rating_api/routes/comment.py Outdated

Zimovchik and others added 10 commits

November 16, 2024 19:51


          fixtures+ tests

debd1de


          lint

12f1340


          refactoring

9a4da78


          lint

b49879e


          delete file

ed30230


          +test_review_comment

a35ce81


          fixes + Register check

ff2548b


          redo create comment for deleted lecturer check

ffba3b5


          added tests and refactoring

94e7cb8


          Merge branch 'main' into timestamp

245ea73

github-actions Bot commented Nov 16, 2024

💩 Code linting failed, use black and isort to fix it.


          linting

6dce58b

github-actions Bot commented Nov 16, 2024

💩 Code linting failed, use black and isort to fix it.


          linting part two

e0786db

zipperman1 requested a review from Zimovchik

November 16, 2024 19:58

Zimovchik requested changes

View reviewed changes

rating_api/routes/comment.py Outdated


          refactoring

987636e

Zimovchik reviewed

View reviewed changes

rating_api/routes/comment.py Outdated


          optimization

223c153

zipperman1 requested a review from Zimovchik

November 17, 2024 15:25

github-actions Bot commented Nov 17, 2024

💩 Code linting failed, use black and isort to fix it.


          lint

d96ca90

Zimovchik requested changes

View reviewed changes

rating_api/routes/comment.py Outdated

tests/test_routes/test_comment.py


          added wrong date test case

3045a5f

Temmmmmo reviewed

View reviewed changes

rating_api/routes/comment.py Outdated

rating_api/routes/comment.py Outdated


          reverted current_time and edited doc

c7391d7

zipperman1 requested review from Temmmmmo and Zimovchik

November 22, 2024 18:29

Temmmmmo reviewed

View reviewed changes

rating_api/routes/comment.py Outdated

rating_api/routes/comment.py Outdated

rating_api/routes/comment.py Outdated


          changed scope and removed redundant checks

7f32918

zipperman1 requested a review from Temmmmmo

November 24, 2024 14:42

Member

Zimovchik commented Nov 24, 2024

резолвни конфликты


          Merge branch 'main' into timestamp

c73f67a

github-actions Bot commented Nov 24, 2024

💩 Code linting failed, use black and isort to fix it.

zipperman1 added 2 commits

November 24, 2024 14:58


          lint

e174ee4


          changed scope name

5a3d43c

Zimovchik approved these changes

View reviewed changes

Temmmmmo reviewed

View reviewed changes

rating_api/routes/comment.py Outdated


          moved db query

08e5d57

github-actions Bot commented Nov 24, 2024

💩 Code linting failed, use black and isort to fix it.

zipperman1 added 2 commits

November 24, 2024 21:46

fix

59c484f


          fix 2

91a022d

Temmmmmo merged commit a82a2bb into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet