Skip to content

Рейтинг преподавателей#6

Merged
Temmmmmo merged 12 commits intomainfrom
1-бэк-рейтинга-преподов
Oct 17, 2024

Hidden character warning

The head ref may contain hidden characters: "1-\u0431\u044d\u043a-\u0440\u0435\u0439\u0442\u0438\u043d\u0433\u0430-\u043f\u0440\u0435\u043f\u043e\u0434\u043e\u0432"
Merged

Рейтинг преподавателей#6
Temmmmmo merged 12 commits intomainfrom
1-бэк-рейтинга-преподов

Conversation

@Temmmmmo
Copy link
Copy Markdown
Member

Изменения

Описано тут

Детали реализации

Тоже можно почитать тут

Check-List

  • Вы проверили свой код перед отправкой запроса? -- в полчетвертого утра уже как-то не до проверок
  • Вы написали тесты к реализованным функциям? -- ага может еще четыре сервиса написать?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End? ну это не забыл)

p.s. кто вообще придумал писать описания к ПРам???

@Temmmmmo Temmmmmo linked an issue Oct 17, 2024 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 17, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py23387%35–36, 44
rating_api/routes
   comment.py662858%37, 43–46, 94–115, 132–135, 149
   exc_handlers.py17288%26, 33
   lecturer.py883165%55, 104–143, 157, 165, 183, 189
rating_api/schemas
   base.py12467%6–9
TOTAL3037276% 

Summary

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 0.894s ⏱️

Comment thread rating_api/routes/comment.py Outdated
Comment thread rating_api/routes/comment.py Outdated
Comment thread rating_api/routes/comment.py Outdated
Comment thread rating_api/routes/comment.py Outdated
Comment thread rating_api/routes/lecturer.py Outdated
Comment thread rating_api/routes/lecturer.py
Comment thread rating_api/routes/lecturer.py
Comment thread rating_api/routes/comment.py Outdated
Comment thread rating_api/routes/lecturer.py
Comment thread models/db.py
Comment thread rating_api/routes/comment.py Outdated
Comment thread migrations/env.py Outdated
Comment thread migrations/versions/dbe6ca79a40d_init.py Outdated
Comment thread models/db.py
Comment thread rating_api/routes/comment.py Outdated
Comment thread rating_api/routes/lecturer.py
@parfenovma
Copy link
Copy Markdown
Contributor

тестов бы ещё напилить)

Comment thread rating_api/routes/comment.py Outdated
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

1 similar comment
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@Temmmmmo
Copy link
Copy Markdown
Member Author

тестов бы ещё напилить)

сделано

@Temmmmmo Temmmmmo merged commit 7264339 into main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Бэк рейтинга преподов

3 participants