Skip to content

Adding profcomff#10 and profcomff#6#11

Merged
Wudext merged 39 commits intoprofcomff:mainfrom
Wudext:Adding-#10
Feb 14, 2023
Merged

Adding profcomff#10 and profcomff#6#11
Wudext merged 39 commits intoprofcomff:mainfrom
Wudext:Adding-#10

Conversation

@Wudext
Copy link
Copy Markdown
Contributor

@Wudext Wudext commented Feb 2, 2023

No description provided.

@Wudext Wudext requested a review from dyakovri February 2, 2023 16:12
Comment thread migrations/versions/670f4caac7dd_init.py
Comment thread services_backend/models/database.py Outdated
Comment thread services_backend/routes/models/button.py
Comment thread services_backend/routes/models/button.py Outdated
mixx3
mixx3 previously approved these changes Feb 3, 2023
Copy link
Copy Markdown
Member

@mixx3 mixx3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

красивое

@mixx3 mixx3 dismissed their stale review February 3, 2023 20:15

link :dict это нехорошо, как я понимаю там должно быть типа AnyHttpUrl

Comment thread .gitignore Outdated
Comment thread migrations/versions/670f4caac7dd_init.py Outdated
Comment thread services_backend/routes/button.py Outdated
Comment thread services_backend/routes/button.py Outdated
Comment thread services_backend/routes/category.py Outdated
Comment thread services_backend/routes/category.py Outdated
Comment thread tests/api/conftest.py Outdated
@grigoriev-semyon
Copy link
Copy Markdown
Member

+6 тестов на логику ордеринга

@Wudext Wudext changed the title Adding #10 Adding #10 and #6 Feb 12, 2023
@Wudext Wudext changed the title Adding #10 and #6 Adding profcomff#10 and profcomff#6 Feb 12, 2023
Copy link
Copy Markdown
Member

@grigoriev-semyon grigoriev-semyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

обсуждали все в Дисе

Comment thread services_backend/routes/button.py Outdated
Comment thread services_backend/routes/button.py Outdated
Comment thread services_backend/routes/button.py
Comment thread services_backend/routes/category.py Outdated
Comment thread services_backend/routes/category.py Outdated
Copy link
Copy Markdown
Member

@grigoriev-semyon grigoriev-semyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уже почти можно мерджить...

Comment thread services_backend/routes/button.py Outdated
@Wudext Wudext merged commit c3318ae into profcomff:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants