Skip to content

Issue #17#26

Merged
Wudext merged 12 commits intomainfrom
Issue-#17
Mar 22, 2023
Merged

Issue #17#26
Wudext merged 12 commits intomainfrom
Issue-#17

Conversation

@Wudext
Copy link
Copy Markdown
Contributor

@Wudext Wudext commented Mar 16, 2023

No description provided.

@Wudext Wudext changed the title Initial commit Issue #17 Mar 16, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 16, 2023

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.10-final-0 ----------

Name Stmts Miss Cover
services_backend/init.py 2 0 100%
services_backend/main.py 4 4 0%
services_backend/exceptions.py 0 0 100%
services_backend/models/init.py 2 0 100%
services_backend/models/base.py 13 4 69%
services_backend/models/database.py 25 0 100%
services_backend/routes/init.py 0 0 100%
services_backend/routes/base.py 15 0 100%
services_backend/routes/button.py 85 13 85%
services_backend/routes/category.py 79 5 94%
services_backend/routes/models/init.py 0 0 100%
services_backend/routes/models/base.py 9 4 56%
services_backend/routes/models/button.py 20 0 100%
services_backend/routes/models/category.py 17 0 100%
services_backend/routes/models/scope.py 6 0 100%
services_backend/routes/scope.py 22 6 73%
services_backend/settings.py 17 0 100%
services_backend/utils/init.py 0 0 100%
TOTAL 316 36 89%
======================= 29 passed, 36

@Wudext Wudext requested a review from grigoriev-semyon March 20, 2023 15:13
Comment thread migrations/versions/6a486347af93_order.py
Comment thread services_backend/routes/category.py
Comment thread services_backend/routes/category.py Outdated
Comment thread services_backend/routes/category.py Outdated
Comment thread services_backend/routes/scope.py Outdated
Comment thread services_backend/routes/models/scope.py Outdated
Comment thread services_backend/routes/scope.py
@Wudext Wudext requested a review from dyakovri March 20, 2023 16:02
Comment thread services_backend/routes/category.py
Comment thread services_backend/routes/scope.py Outdated
Copy link
Copy Markdown
Member

@dyakovri dyakovri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще хочется тесты

  1. Категорию без скоупсов может получить незалогин
    2 Категорию без скоупсов может получить залогин
  2. Категорию с скоупсами не может получить незалогин
  3. Категорию с скоупсами не может получить залогин с непересекающимся набором скоупсов
  4. Категорию с скоупсами может получить залогин с необходимым скоупом

Comment thread services_backend/routes/scope.py Outdated
Comment thread services_backend/routes/scope.py Outdated
@Wudext Wudext requested a review from dyakovri March 20, 2023 16:45
@Wudext Wudext merged commit d247741 into main Mar 22, 2023
@Wudext Wudext deleted the Issue-#17 branch March 22, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Категории кнопок для зарегистрированных пользователей

3 participants