Skip to content

Issues #22, #28, #29, README.md update#30

Merged
Wudext merged 24 commits intomainfrom
#22-#28-#29-README
Apr 10, 2023
Merged

Issues #22, #28, #29, README.md update#30
Wudext merged 24 commits intomainfrom
#22-#28-#29-README

Conversation

@Wudext
Copy link
Copy Markdown
Contributor

@Wudext Wudext commented Mar 30, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2023

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.10-final-0 ----------

Name Stmts Miss Cover
services_backend/init.py 2 0 100%
services_backend/main.py 4 4 0%
services_backend/exceptions.py 0 0 100%
services_backend/models/init.py 2 0 100%
services_backend/models/base.py 13 4 69%
services_backend/models/database.py 31 0 100%
services_backend/routes/init.py 0 0 100%
services_backend/routes/base.py 15 0 100%
services_backend/routes/button.py 85 13 85%
services_backend/routes/category.py 79 5 94%
services_backend/routes/models/init.py 0 0 100%
services_backend/routes/models/base.py 9 4 56%
services_backend/routes/models/button.py 22 0 100%
services_backend/routes/models/category.py 18 0 100%
services_backend/routes/models/scope.py 6 0 100%
services_backend/routes/scope.py 22 6 73%
services_backend/settings.py 17 0 100%
services_backend/utils/init.py 0 0 100%
TOTAL 325 36 89%
======================= 29 passed, 36

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

Copy link
Copy Markdown
Member

@grigoriev-semyon grigoriev-semyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вижу костыль на один ишью из трех
Пайдентик должен справляться с таким сам

Comment thread .gitignore Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread services_backend/routes/button.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2023

💩 Code linting failed, use black and isort to fix it.

Comment thread services_backend/routes/models/category.py
Comment thread services_backend/routes/button.py Outdated
Comment thread services_backend/routes/button.py Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@grigoriev-semyon
Copy link
Copy Markdown
Member

еще не вижу миграции соответствующей на уход от сквозной нумерации

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2023

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2023

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2023

💩 Code linting failed, use black and isort to fix it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2023

💩 Code linting failed, use black and isort to fix it.

@Wudext Wudext requested a review from grigoriev-semyon April 8, 2023 05:55
@Wudext Wudext linked an issue Apr 8, 2023 that may be closed by this pull request
Comment thread migrations/versions/6a486347af93_order.py Outdated
Comment thread migrations/versions/6a486347af93_order.py Outdated
Comment thread migrations/versions/6a486347af93_order.py Outdated
Comment thread services_backend/routes/models/button.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2023

💩 Code linting failed, use black and isort to fix it.

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated
Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated
Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated
Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

Comment thread migrations/versions/6a486347af93_order.py
Comment thread migrations/versions/6a486347af93_order.py Outdated
Comment thread migrations/versions/6a486347af93_order.py Outdated
Copy link
Copy Markdown
Member

@grigoriev-semyon grigoriev-semyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уж не знаю как эти миграции запускаются если ты их вообще тестишь

@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated
@github-actions
Copy link
Copy Markdown

💩 Code linting failed, use black and isort to fix it.

@Wudext Wudext requested a review from grigoriev-semyon April 10, 2023 11:29
@Wudext Wudext merged commit 2ab24f6 into main Apr 10, 2023
@Wudext Wudext deleted the #22-#28-#29-README branch April 10, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants