Issues #22, #28, #29, README.md update by Wudext · Pull Request #30 · profcomff/services-api

Wudext · 2023-03-30T15:14:50Z

No description provided.

github-actions · 2023-03-30T15:15:22Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-03-30T15:16:15Z

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.10-final-0 ----------

Name	Stmts	Miss	Cover
services_backend/init.py	2	0	100%
services_backend/main.py	4	4	0%
services_backend/exceptions.py	0	0	100%
services_backend/models/init.py	2	0	100%
services_backend/models/base.py	13	4	69%
services_backend/models/database.py	31	0	100%
services_backend/routes/init.py	0	0	100%
services_backend/routes/base.py	15	0	100%
services_backend/routes/button.py	85	13	85%
services_backend/routes/category.py	79	5	94%
services_backend/routes/models/init.py	0	0	100%
services_backend/routes/models/base.py	9	4	56%
services_backend/routes/models/button.py	22	0	100%
services_backend/routes/models/category.py	18	0	100%
services_backend/routes/models/scope.py	6	0	100%
services_backend/routes/scope.py	22	6	73%
services_backend/settings.py	17	0	100%
services_backend/utils/init.py	0	0	100%
TOTAL	325	36	89%
=======================	29	passed,	36

github-actions · 2023-03-30T15:16:59Z

💩 Code linting failed, use black and isort to fix it.

grigoriev-semyon

Вижу костыль на один ишью из трех
Пайдентик должен справляться с таким сам

…vices-api into #22-#28-#29-README

github-actions · 2023-04-06T07:41:39Z

💩 Code linting failed, use black and isort to fix it.

grigoriev-semyon · 2023-04-06T12:06:02Z

еще не вижу миграции соответствующей на уход от сквозной нумерации

github-actions · 2023-04-07T18:30:59Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-04-07T19:34:33Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-04-07T19:36:10Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-04-08T05:54:21Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-04-09T11:00:21Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-04-10T10:54:57Z

💩 Code linting failed, use black and isort to fix it.

grigoriev-semyon

уж не знаю как эти миграции запускаются если ты их вообще тестишь

github-actions · 2023-04-10T11:19:37Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2023-04-10T11:25:27Z

💩 Code linting failed, use black and isort to fix it.

Initial commit

155cb13

Black doesn`t like me :(

ef3c496

ISort

9945876

Wudext requested review from dyakovri and grigoriev-semyon March 30, 2023 15:51

grigoriev-semyon requested changes Mar 31, 2023

View reviewed changes

Wudext added 6 commits March 31, 2023 16:29

Update category.py

6dfb524

Fixing #22

16cabed

Update .gitignore

f22b360

CONTRIBUTING.md and README.md

e44e6f2

Merge branch '#22-#28-#29-README' of https://github.com/profcomff/ser…

1d4f44a

…vices-api into #22-#28-#29-README

Descriptions

4cb350a

Wudext added 2 commits April 6, 2023 10:43

Black and Isort (again)

3baf8cf

Final commit (i hope)

7c43f85

grigoriev-semyon requested changes Apr 6, 2023

View reviewed changes

Comment thread services_backend/routes/models/category.py

Comment thread services_backend/routes/button.py Outdated

Comment thread services_backend/routes/button.py Outdated

Comment thread README.md Outdated

Comment thread README.md Outdated

Wudext added 2 commits April 6, 2023 15:10

Update button.py

1dd9056

Enum + README + migrations

90b8f90

Update conftest.py

73518e7

Update button.py

7f3718c

Wudext added 2 commits April 8, 2023 08:51

Fixing migrations

ec098ec

Black and Isort (надоели уже)

767b2d3

Wudext requested a review from grigoriev-semyon April 8, 2023 05:55

Wudext linked an issue Apr 8, 2023 that may be closed by this pull request

Типы кнопок в формате enum #32

Closed

grigoriev-semyon requested changes Apr 8, 2023

View reviewed changes

Comment thread migrations/versions/6a486347af93_order.py Outdated

Comment thread migrations/versions/6a486347af93_order.py Outdated

Comment thread migrations/versions/6a486347af93_order.py Outdated

grigoriev-semyon reviewed Apr 8, 2023

View reviewed changes

Comment thread services_backend/routes/models/button.py Outdated

Fixing

27361ad

grigoriev-semyon requested changes Apr 9, 2023

View reviewed changes

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated

Last commint (again)

11459c1

grigoriev-semyon reviewed Apr 10, 2023

View reviewed changes

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated

grigoriev-semyon reviewed Apr 10, 2023

View reviewed changes

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated

Please let it end

56e9d52

grigoriev-semyon reviewed Apr 10, 2023

View reviewed changes

Comment thread migrations/versions/6a486347af93_order.py

grigoriev-semyon reviewed Apr 10, 2023

View reviewed changes

Comment thread migrations/versions/6a486347af93_order.py Outdated

grigoriev-semyon reviewed Apr 10, 2023

View reviewed changes

Comment thread migrations/versions/6a486347af93_order.py Outdated

grigoriev-semyon requested changes Apr 10, 2023

View reviewed changes

Wudext added 2 commits April 10, 2023 14:19

Update 6a486347af93_order.py

fbc2b4b

Black (3d time)

ecc1a90

grigoriev-semyon requested changes Apr 10, 2023

View reviewed changes

Comment thread migrations/versions/d35e88f39f85_fixing.py Outdated

Wudext added 2 commits April 10, 2023 14:24

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

c7e0c6b

Update d35e88f39f85_fixing.py

f8ebef9

Wudext requested a review from grigoriev-semyon April 10, 2023 11:29

grigoriev-semyon approved these changes Apr 10, 2023

View reviewed changes

Wudext merged commit 2ab24f6 into main Apr 10, 2023

Wudext deleted the #22-#28-#29-README branch April 10, 2023 11:33

Conversation

Wudext commented Mar 30, 2023

Uh oh!

github-actions Bot commented Mar 30, 2023

Uh oh!

github-actions Bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Result of Pytest Coverage

Uh oh!

github-actions Bot commented Mar 30, 2023

Uh oh!

grigoriev-semyon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grigoriev-semyon commented Apr 6, 2023

Uh oh!

github-actions Bot commented Apr 7, 2023

Uh oh!

github-actions Bot commented Apr 7, 2023

Uh oh!

github-actions Bot commented Apr 7, 2023

Uh oh!

github-actions Bot commented Apr 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grigoriev-semyon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 10, 2023

Uh oh!

Uh oh!

github-actions Bot commented Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Mar 30, 2023 •

edited

Loading

grigoriev-semyon left a comment •

edited

Loading