Skip to content

Conversation

@jnavila
Copy link
Member

@jnavila jnavila commented Mar 23, 2018

Not yet ready for merge

jnavila added 2 commits March 21, 2018 20:27
Use the convert task and rework other files
@jnavila
Copy link
Member Author

jnavila commented Mar 23, 2018

Well, it passed! @andres-mancera Would you like to review the changes before the merge?

@andres-mancera
Copy link
Member

Thanks @jnavila ! So you want me to go over the 489 changed files, review them and bless this merge? 😆 It'll be probably easier to merge and then go over the book and fix any issues at that point. What do you think?

@jnavila
Copy link
Member Author

jnavila commented Mar 27, 2018

Well, most of the changes are only cross-ref updates and removals of remainings of conflicts marks. That's mainly for what's left that I'm not sure of. I guess we can merge.

@jnavila jnavila merged commit 980010a into master Mar 27, 2018
@jnavila jnavila deleted the ebook-pub branch March 27, 2018 19:20
@andres-mancera
Copy link
Member

Cool, thanks a lot! Will the book get built now every time there is a commit? If so, where can we find the latest version of the book?

@jnavila
Copy link
Member Author

jnavila commented Mar 27, 2018

The book is built only on tags. Tags are automatically created on master only.
Books are available at https://github.com/progit/progit2-es/releases and the url will be daily updated on git-scm.com.

@andres-mancera
Copy link
Member

If I remember correctly, the book that was generated by the old build process contained a page that basically came directly from the contributors file. I no longer see that as part of the new book. Any idea what happened? IMO, having the names of the translators as part o the book was a nice token of appreciation.

@jnavila
Copy link
Member Author

jnavila commented Mar 28, 2018

It can still be added.

@jnavila
Copy link
Member Author

jnavila commented Mar 28, 2018

The trick here is that it has to be extracted from the present repository and won't reflect the contributors to the original book.

@jnavila
Copy link
Member Author

jnavila commented Mar 28, 2018

The list is generated automatically now. You can modify the people appearing by changing the .mailmap file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants