fix some adoc syntax and http links (solve #121) #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
원인
#121 에서 발생한 action 빌드 오류 처리
오류: https://github.com/progit/progit2-ko/actions/runs/1053350094
github의 action이랑 현재 빌드하는게 좀 다른가?
"release-on-merge.yml" 추가되면서 각 repository의 rakefile 이용해서 빌드 하는 것이 아니라 중앙 집중식으로 build 스크립트를 관리하고 있다.
새 rake 파일의 htmlproofer 에서 오류
더 깐깐하게 html을 체크하기에 문법 오류를 일부 고쳐서 merge 한다.
epubcheck: Failed to execute epubcheck. 오류
현재 progit2-ko의 dockerfile로 생성한 container에서 epubcheck(epubcheck-ruby)의 실행이 잘 되지 않는다. 관련 dependency가 없는 것인가?
epubcheck-ruby는 epubcheck(java)를 wrapping하는 라이브러리. 따라서 java 필요함. apt-get install -y openjdk-8-jre